Allow skipping marking hasNewContent in formatContentModel
#2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/roosterjs-content-model-core/lib/coreApi/formatContentModel/formatContentModel.ts:51
- [nitpick] The variable name 'minMaxImageSize' in the 'handleImages' function is ambiguous. It should be renamed to 'minImageSize'.
const shouldAddSnapshot = (!skipUndoSnapshot || skipUndoSnapshot == 'DoNotSkip') && !isNested;
| */ | ||
| skipUndoSnapshot?: boolean; | ||
| skipUndoSnapshot?: boolean | 'DoNotSkip' | 'MarkNewContent' | 'SkipAll'; |
There was a problem hiding this comment.
The comment for the skipUndoSnapshot parameter is unclear. It should be clarified that true is equivalent to 'MarkNewContent'.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
juliaroldi
approved these changes
Jan 31, 2025
JiuqingSong
added a commit
that referenced
this pull request
Feb 7, 2025
* remove margins on Autoformat plugin * fixes * fix * remove data-istrue * use content change * refactor * Allow skipping marking hasNewContent in `formatContentModel` (#2933) * Fix bridge plugin to be able to handle new event (#2935) * Fix bridge plugin to be able to handle new event * add test * clean LegacySelectionPlugin * Send anchor event in Auto Link (#2934) After a text is automatically transformed into a link by typing and pressing space, send the anchor element when the ContentChanged event is triggered. Also add more unit tests. * Respect font weight in TH element (#2939) * Respect font weight in TH element * add test * improve * fix build * Fix resize table with width (#2940) * Fix resize table with width * fix test * version bump --------- Co-authored-by: Julia Roldi (from Dev Box) <juliaroldi@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a parameter
skipUndoSnapshotinformatContentModelcontext object to allow skipping adding undo snapshot. When it is set to true,formatContentModelwill not add undo snapshot but it will markhasNewContentto be true so next time undo is performed, we will first add an undo snapshot then undo.But in some scenario we don't even want to mark
hasNewContentas well, so in this PR I modified this parameter to let it allow 3 different values in addition to existing true | false value: