Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(mc): Create helm-release module #1303

Merged
merged 2 commits into from
Feb 5, 2025
Merged

test(mc): Create helm-release module #1303

merged 2 commits into from
Feb 5, 2025

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Feb 4, 2025

Description

  • create helm-release module
  • delete retina and prometheus modules
  • refactor integration tests as needed

Related Issue

#1267

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Screenshot 2025-02-04 093852
Screenshot 2025-02-04 114057

Additional Notes

Add any additional notes or context about the pull request here.

Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi self-assigned this Feb 4, 2025
@SRodi SRodi requested a review from a team as a code owner February 4, 2025 16:07
@SRodi SRodi changed the title test(mc): Create helm-release module, del retina and prometheus test(mc): Create helm-release module Feb 4, 2025
@SRodi SRodi added this pull request to the merge queue Feb 5, 2025
Merged via the queue into microsoft:main with commit dec4e39 Feb 5, 2025
29 checks passed
@SRodi SRodi deleted the mc/helm-module branch February 5, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibezrukavyi ibezrukavyi ibezrukavyi approved these changes

@xiaozhiche320 xiaozhiche320 Awaiting requested review from xiaozhiche320 xiaozhiche320 is a code owner automatically assigned from microsoft/retina

@karina-ranadive karina-ranadive Awaiting requested review from karina-ranadive karina-ranadive is a code owner automatically assigned from microsoft/retina

Assignees

@SRodi SRodi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SRodi @ibezrukavyi