Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WinUI/MUX to 2.7 #8726

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Upgrade WinUI/MUX to 2.7 #8726

merged 3 commits into from
Oct 26, 2021

Conversation

jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Sep 28, 2021

This PR upgrades our MUX dependency from 2.6 to 2.7.

Closes #8724

Microsoft Reviewers: Open in CodeFlow

This PR upgrades our MUX dependency from 2.6 to 2.7.

Closes microsoft#8724
@jonthysell jonthysell requested a review from a team as a code owner September 28, 2021 17:51
@asklar
Copy link
Member

asklar commented Sep 28, 2021

current 2.7 prerelease has a bug for xaml islands so we should hold off. See microsoft/microsoft-ui-xaml#5793

@jonthysell
Copy link
Contributor Author

current 2.7 prerelease has a bug for xaml islands so we should hold off. See microsoft/microsoft-ui-xaml#5793

Is this fixed in the later 2.7.0-prerelease.210913003 (which is what I put in the PR)?

Or alternatively, does it repro in Microsoft.UI.Xaml.2.7.0-prerelease.210816001? which is what FB is using.

@asklar
Copy link
Member

asklar commented Sep 28, 2021

yes, 210816001 will reproduce the problem

@jonthysell
Copy link
Contributor Author

Playground win32 builds just fine with 2.7.0-prerelease.210913003, which no longer depends on WebView2.

@NickGerleman
Copy link
Collaborator

We ought to start testing some community modules in our repo against canary builds. Like, a CI job that tries to build gallery against its latest bits.

@NickGerleman
Copy link
Collaborator

NickGerleman commented Oct 6, 2021

That was re things like having coverage we can compile react-native-webview.

@jonthysell jonthysell merged commit d76872d into microsoft:main Oct 26, 2021
@asklar
Copy link
Member

asklar commented Oct 26, 2021

woot :) 🎉
should this go into 67? if so we need to port it to the 0.67-stable branch

@jonthysell
Copy link
Contributor Author

woot :) 🎉 should this go into 67? if so we need to port it to the 0.67-stable branch

I think so, along with #8723.

jonthysell added a commit to jonthysell/react-native-windows that referenced this pull request Oct 26, 2021
This PR upgrades our MUX dependency from 2.6 to 2.7.

Closes microsoft#8724
@jonthysell jonthysell deleted the winui27 branch October 26, 2021 18:37
jonthysell added a commit that referenced this pull request Oct 26, 2021
This PR upgrades our MUX dependency from 2.6 to 2.7.

Closes #8724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade WinUI 2.6 to WinUI 2.7
3 participants