Implement ISelectionProvider and ISelectionItemProvider

[chiaramooney]

Description

Type of Change

• New feature (non-breaking change which adds functionality)

Why

Accessibility on the new architecture should reach parity with Paper.

Resolves #13064
Resolves #13060
Resolves #13056
Resolves #13052
Resolves #13048
Resolves #13044
Resolves #13040
Resolves #13036
Resolves #13032
Resolves #12047
#13327
#13316

Resolves #13354
Resolves #13353

What

• Adds support for ISelectionProvider interface
• Adds support for ISelectionItemProvider interface
• Adds support for accessibilityState:selected
• Adjusts AccessibilityState native type on Windows to be std::optional instead of bool
• Adjusts AccessibilityState native type on Windows to include multiselectable and required fields of type std::optional
• Adds multiselectable and required fields to AccessibilityState type in JS with type boolean | undefined
• Adds support for aria-multiselectable and aria-required.
• Adds support for the following accessibilityActions: addToSelection, removeFromSelection, select
• Fixes crash in AccessibilityInsights.

Testing

Locally tested for:

• ISelectionItemProvider: AddToSelection, RemoveFrommSelection, Select, get_IsSelected, get_SelectionContainer
• ISelectionProvider:  GetSelection, get_CanSelectMultiple, get_IsSelectionRequired
• Parent as selection container, Non-parent ancestor as selection container
• Adding/Removing SelectionItem from the Visual Tree
• Adding/Removing SelectionContainer from Visual Tree
• Calling addToSelection, removeFromSelection, and select accessibilityActions
• Adjusting values of accessibilityState multiselectable and required
• Child views that aren't selectable items
• Selection of multiple items

Changelog

Should this change be included in the release notes: Yes

[danielayala94]

In general, I didn't understand when and what should be addRef'd. If you can provide some clarity here, it would be helpful.

My sincere advice here is to move into smart pointers. Then, there won't be a need to manually manage memory for each and every object. In Windows, we rely on the winrt library (see winrt::com_ptr) to work with COM interfaces.

https://learn.microsoft.com/en-us/uwp/cpp-ref-for-winrt/com-ptr
https://learn.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/consume-com

[chiaramooney]

In general, I didn't understand when and what should be addRef'd. If you can provide some clarity here, it would be helpful.

My sincere advice here is to move into smart pointers. Then, there won't be a need to manually manage memory for each and every object. In Windows, we rely on the winrt library (see winrt::com_ptr) to work with COM interfaces.

https://learn.microsoft.com/en-us/uwp/cpp-ref-for-winrt/com-ptr https://learn.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/consume-com

So unfortunately the methods here are defined by UIA (we are just adding implementations for them) so I can't change the type values of the IRawElementProviderFragment** types in most cases.

My understanding is if we are returning a reference to an object then we need to AddRef so the object is not destroyed prematurely. In the cases when we don't add AddRef but it is needed the app will crash when the program executes.

[jonthysell]

Will these ever get upstreamed? Are the new props actually from aria?

[chiaramooney]

Hard to say. I will file an issue to request they get upstreamed but it seems RN only decided to implement a subset of the aria props. The new props are real aria props. Meta just hasn't integrated them into the platform. Maybe they aren't needed for accessibility on mobile?

[danielayala94]