Updating native WebSocket header logic to match RN

[slswalker]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Why

There are two bugs at play. This fixes both bugs, allowing headers to be properly used with web socket requests.

Bug #1
In Libraries/WebSocket/WebSocket.js, the expected type for headers is an object. This is passed down as-is to the native layer in the call NativeWebSocketModule.connect(url, protocols, {headers}, this._socketId);. The turbo module implementation attempts to iterative over this box type by using .AsArray(), which immediately continues past the for-loop. The result is that any headers passed down from Javascript are ignored.

Bug #2
React Native WebSocket implementations do not put a port on the Origin header when a port is not provided. RNW does, which results in adding a port of 0 to every default Origin header. Port 0 is reserved and is not meant to be used.

The combination of both of these bugs means every web socket request will only have one header and it will be a improperly constructed Origin header.

Resolves [Add Relevant Issue Here]
While I don't know which version of RNW this was introduced in, when Xbox updated an app from RNW 0.69 to 0.73, all web socket requests broke due to services rejecting origin headers wiht port 0. This works fine on mobile apps due.

What

• WebSocketModule.cpp: Changed the usage of .AsArray() to .AsObject() to match expectations of headers type that is passed down by Javascript
• WinRTWebSocketResource.cpp: Changed default origin header construction to only add a port if it is not 0.

Testing

Xbox is currently using a patch that applies both of these changes.

Changelog

yes?

WebSocket headers are now properly applied when using Turbo Modules

Microsoft Reviewers: Open in CodeFlow

[JunielKatarn]

Thanks for your submission.

Regarding issue number 1, headers were not explicitly typed as Object till March 2023:
https://github.com/facebook/react-native/blame/1b2992e8b35e500104d07d38adb2ea5a1d98d3ed/Libraries/WebSocket/NativeWebSocketModule.js
https://github.com/facebook/react-native/blame/1d3349e968d42d99813115e3f5db204210e149d4/packages/react-native/Libraries/WebSocket/NativeWebSocketModule.js

[JunielKatarn]

For follow-up:

While this change prevents from appending a port with value 0 when the intended value may have been the protocol defaults (80, 443), this would prevent a client app from explicitly using such port, even though it's against conventions and possibly standards.

We should use the same URL processing as OriginPolicyHttpFilter.cpp to prevent a few corner cases such as explicitly set default ports.
See #12626 and OfficeDev/office-js#4144.