-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CompositionSwitcher to Experimental namespace #12960
Merged
acoates-ms
merged 9 commits into
microsoft:main
from
acoates-ms:movecompswitchertoexperimental
Apr 23, 2024
Merged
Move CompositionSwitcher to Experimental namespace #12960
acoates-ms
merged 9 commits into
microsoft:main
from
acoates-ms:movecompswitchertoexperimental
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
microsoft-github-policy-service
bot
added
the
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
label
Apr 23, 2024
jonthysell
reviewed
Apr 23, 2024
@@ -3,7 +3,6 @@ | |||
|
|||
<PropertyGroup Label="Microsoft.ReactNative Experimental Features"> | |||
<UseHermes>true</UseHermes> | |||
<UseFabric>true</UseFabric> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe just leave in as <UseFabric>false</UseFabric>
?
jonthysell
approved these changes
Apr 23, 2024
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Apr 23, 2024
* Move CompositionSwitcher to Experimental namespace * Change files * fix * fix * fix * format * fix * fix * format
acoates-ms
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Fabric
Support Facebook Fabric
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the objects related to the composition switcher into an Experimental namespace.
On public objects that used to expose objects from the switcher we now directly expose Microsoft.UI.Composition objects. There are experimental interfaces that can be used to set composition switcher objects instead.
This should limit the effect of the switcher on the public interface. We still use the switcher internally to allow Office to be able to continue to inject a custom composition interface. But now when we remove this ability APIs outside of the experimental namespace should not need to change.
Example:
Before:
After:
Microsoft Reviewers: Open in CodeFlow