Workaround fix for "missing-asset-registry-path" error to unblock PRs #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New app projects built against main are unable to create their bundle (see microsoft#11437). As such, all PRs are blocked as the New CLI app checks all fail. The problem is that the metro config needs `transformer.assetRegistryPath` to be set to the location of `./Libraries/Image/AssetRegistry`, which for our purposes is the copy located in the RNW folder. For some reason this isn't set anymore. This PR adds a workaround of specifying that path in our app template's metro.config.js file. This unblocks our PRs but we should probably find a better place than in an app template file. Resolves microsoft#11437
|
This change will break all other platforms. -- it might be needed as a temp unblock tho |
Right, I don't know of better place to put it unless we want to wait for an upstream fix. Do we still have no way of making a change to metro.config.js that is one platform only? |
|
For now we can at least set it to: That will work for all platforms, since we redirect any react-native import to react-native-windows when building windows packages. |
|
@acoates-ms The string you suggested appears to work. Care to sign-off? |
marlenecota
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New app projects built against main are unable to create their bundle (see #11437).
As such, all PRs are blocked as the New CLI app checks all fail.
The problem is that the metro config needs
transformer.assetRegistryPathto be set to the location of'react-native/Libraries/Image/AssetRegistry', as for some reason this isn't set anymore upstream.This PR adds a workaround of specifying that path in our app template's metro.config.js file. This unblocks our PRs but we should probably find a better place than in an app template file.
Type of Change
Why
Unblock our PRs.
Resolves #11437
What
Updates the new app template's metro.config.js file with the correct path which is no longer getting set for us.
Screenshots
N/A
Testing
Tested with a new CLI app.
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow