Add E2E Test App for Fabric #11407

chiaramooney · 2023-03-21T23:12:28Z

Description

Type of Change

New feature (non-breaking change which adds functionality)

Why

Adds E2E Test App which uses the new architecture.

#11422

What

Adds E2E Test App which uses the new architecture. App renders same content as original E2E test app.

Microsoft Reviewers: Open in CodeFlow

…ayground directory

into cm-fabric-e2e

packages/e2e-test-app-fabric/CHANGELOG.json

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp

yarn.lock

packages/e2e-test-app-fabric/.gitignore

...ages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/Generated Files/msbuildproperties.g.json

jonthysell · 2023-03-22T18:15:51Z

packages/e2e-test-app-fabric/windows/ExperimentalFeatures.props

+      Playground-Win32 is an unpackaged win32 app, and needs to use Microsoft.UI.Xaml from a prerelease,
+      to be able to carry WinUI in-app instead of using the Framework Package
+    -->
+    <WinUI2xVersion>2.7.0-prerelease.210913003</WinUI2xVersion>


@acoates-ms How should we be handling XAML in an explicitly Fabric comp app? Eventually we'll be able to host XAML with content islands. Does that mean all RNW apps will have to use pre-release (non-Framework) WinUI packages? Should we be ifndef-ing all WinUI code when Fabric is enabled so XAML isn't depended on by M.RN at all? Will we only support WinUI3 content islands?

Right now since no hosting of XAML is being done, it should all work with Win2 or 3. But when we get to hosting that would be 3 only. So we should probably make the test app winui3 from the start.

Alternatively, we could make the test app a win32 app with no XAML. -- Which I think aligns with the playground app.

As this is going to inform our app template, I would love to leave XAML out for now if possible. It would be nice to make XAML strictly opt-in (esp. if we end up not needing XAML for any core components).

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.vcxproj

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp

jonthysell · 2023-03-22T19:12:46Z

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric.sln

While I'm okay with the package being named e2e-test-app-fabric while we work on it, is there any reason to name all of the files with -Farbic? Everything within the code still just refers to the app as RNTester (namespaces, strings) so maybe we just leave it all as RNTester? Thoughts?

I'm flexible! In the original e2e-test-app, the name RNTesterApp is used. We could replicate that here, if we don't want to add the -Fabric specifier.

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp

jonthysell · 2023-03-22T19:19:40Z

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp

There's a bunch of stuff in here we'll want to (eventually) move into a more re-usable place, maybe trying to follow the example of CoreApp, but it doesn't have to be in this particular initial PR.

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Co-authored-by: Chris Glein <26607885+chrisglein@users.noreply.github.com>

…-native-windows into cm-fabric-e2e

…ve-windows into cm-test2

Merge

into cm-fabric-e2e

jonthysell · 2023-03-30T22:07:17Z

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.vcxproj

+    <!-- https://github.com/microsoft/react-native-windows/issues/8591 -->
+    <RunAutolinkCheck>false</RunAutolinkCheck>


we can leave it for now.

jonthysell · 2023-03-30T22:08:21Z

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.vcxproj

+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>true</UseDebugLibraries>
+    <PlatformToolset>v143</PlatformToolset>


This might be and example of something we have to put in the Win32 props sheet that we didn't need for UWP apps.

## Description ### Type of Change - Code Edits ### Why Adding some of the coding feedback that arose during #11407 into the Playground Composition source for consistency. Resolves #11413

chiaramooney added 14 commits March 15, 2023 11:01

Save State: App builds and deploys, loads JS when metro started in pl…

6ef0b8b

…ayground directory

Save State: Basic E2E Test App Working!

a5575f2

Remove CompositionHost

baf9efe

Shift File Names

2b4e2ea

Save State: Automatic App Launch

03ad746

Save State: Remove Settings and New Window Code

58a0e2e

Save State: Remove Menu Completely

1b082fd

Save State: Remove Unneeded .h Files

339b889

Merge

757eaef

Remove Tests + Alter Entry to index

bd27e77

Remove Sample Entry

3b85202

Clean Up, Remove Excess Macros

95628a0

Remove Extra

ff399ec

Remove Extra File

f605744

jonthysell added the Area: Fabric Support Facebook Fabric label Mar 21, 2023

chiaramooney added 2 commits March 22, 2023 10:40

Merge branch 'main' of https://github.com/microsoft/react-native-windows

b0a76b4

into cm-fabric-e2e

Merge

0b8ba9c

acoates-ms reviewed Mar 22, 2023

View reviewed changes

packages/e2e-test-app-fabric/CHANGELOG.json Outdated Show resolved Hide resolved

acoates-ms reviewed Mar 22, 2023

View reviewed changes

packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp Show resolved Hide resolved

acoates-ms reviewed Mar 22, 2023

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

jonthysell reviewed Mar 22, 2023

View reviewed changes

chiaramooney and others added 9 commits March 22, 2023 13:21

Address Feedback

e6ebbca

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

155ffc3

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

77d29d4

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

8534d2a

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

ed04c2c

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

214982e

Co-authored-by: Jon Thysell <jthysell@microsoft.com>

Address Feedback

47c255c

Address Feedback

5b20922

Address Feedback

f8cc221

chiaramooney and others added 17 commits March 28, 2023 13:57

Address Feedback

29e690b

Co-authored-by: Chris Glein <26607885+chrisglein@users.noreply.github.com>

Address Feedback

00a19f9

Co-authored-by: Chris Glein <26607885+chrisglein@users.noreply.github.com>

Address Feedback

5e5b8a0

Add YML

0bf1b51

Fix

3a1ed66

Rename Index

f6bdc5f

Adjust Pipeline

0840294

Adjust Pipeline

b3afcd8

Merge branch 'cm-fabric-e2e' of https://github.com/chiaramooney/react…

c8a865c

…-native-windows into cm-fabric-e2e

Delete Bundle

6a2928a

Merge

c4cdd59

Merge branch 'cm-test2' of https://github.com/chiaramooney/react-nati…

0414216

…ve-windows into cm-test2

Delete msbuildproperties.g.json

48aac50

Alter App.json

51d45ff

Merge branch 'cm-test2' of https://github.com/chiaramooney/react-nati…

818a2e0

…ve-windows into cm-test2

Merge pull request #302 from chiaramooney/cm-test2

5027aae

Merge

Merge branch 'main' of https://github.com/microsoft/react-native-windows

36b4397

into cm-fabric-e2e

chiaramooney mentioned this pull request Mar 29, 2023

E2E testing for Fabric #11422

Open

chrisglein assigned jonthysell Mar 29, 2023

Merge branch 'main' into cm-fabric-e2e

41eb047

jonthysell approved these changes Mar 30, 2023

View reviewed changes

chiaramooney removed request for chrisglein and acoates-ms March 30, 2023 22:27

jonthysell approved these changes Mar 30, 2023

View reviewed changes

TatianaKapos approved these changes Mar 30, 2023

View reviewed changes

chiaramooney merged commit d5d19f5 into microsoft:main Mar 30, 2023

chiaramooney deleted the cm-fabric-e2e branch March 30, 2023 22:40

chiaramooney mentioned this pull request Jun 9, 2023

Add Coding Fixes to Composition Playground #11739

Merged

jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add E2E Test App for Fabric #11407

Add E2E Test App for Fabric #11407

chiaramooney commented Mar 21, 2023 •

edited

Loading

jonthysell Mar 22, 2023

acoates-ms Mar 27, 2023

jonthysell Mar 30, 2023

jonthysell Mar 22, 2023

chiaramooney Mar 22, 2023

jonthysell Mar 22, 2023

jonthysell Mar 30, 2023

jonthysell Mar 30, 2023

		<!-- https://github.com/microsoft/react-native-windows/issues/8591 -->
		<RunAutolinkCheck>false</RunAutolinkCheck>

Add E2E Test App for Fabric #11407

Add E2E Test App for Fabric #11407

Conversation

chiaramooney commented Mar 21, 2023 • edited Loading

Description

Type of Change

Why

What

Microsoft Reviewers: Open in CodeFlow

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiaramooney commented Mar 21, 2023 •

edited

Loading