-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in KeyboardEventHandler when no corewindow #8063
Comments
ghost
added
the
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
label
Jun 18, 2021
asklar
added
Area: WinUI
and removed
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
labels
Jun 24, 2021
will need to try this out in winappsdk 1.0 once we update |
10 tasks
@TatianaKapos Do you think this will make 0.69 or should it be moved to 0.70? |
Heads up: I have a fix for this. Will put up PR shortly. |
jonthysell
pushed a commit
that referenced
this issue
Nov 15, 2022
…ng unsupported class (#10859) [Per WinAppSDK the CoreWindow class is unsupported](https://docs.microsoft.com/en-us/windows/apps/desktop/modernize/desktop-to-uwp-supported-api#core-unsupported-classes). It's used in KeyboardEventHandler for calling GetKeyState, which the docs provide an alternative: > Instead of the [GetKeyState](https://docs.microsoft.com/en-us/uwp/api/windows.ui.core.corewindow.getkeystate) method, use the [InputKeyboardSource.GetKeyStateForCurrentThread](https://docs.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.input.inputkeyboardsource.getkeystateforcurrentthread) method provided by WinUI 3 instead. This PR makes that change. Resolves #8063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
note that there are more usages of corewindow in this file that we need to provide alternatives when no corewindow is available
react-native-windows/vnext/Microsoft.ReactNative/Views/KeyboardEventHandler.cpp
Lines 200 to 207 in 003602b
The text was updated successfully, but these errors were encountered: