Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Flyout out of react-native-windows and into a community module #4343

Open
chrisglein opened this issue Mar 18, 2020 · 3 comments
Open

Move Flyout out of react-native-windows and into a community module #4343

chrisglein opened this issue Mar 18, 2020 · 3 comments
Labels
Area: Flyout enhancement Extensions Tracks issues against community modules and extensions Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Milestone
Backlog

Comments

@chrisglein
Copy link
Member

This component is added by react-native-windows but we shouldn't be adding anything on top of what's in react-native core. This component should be added via a community module instead.
@chrisglein chrisglein added vnext enhancement Extensions Tracks issues against community modules and extensions Area: Flyout labels Mar 18, 2020
@chrisglein chrisglein added this to the 0.63 (M6) milestone Mar 18, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Mar 18, 2020
@chrisglein chrisglein mentioned this issue Mar 18, 2020
Closed
@chrisglein chrisglein removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) vnext labels Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.63, Backlog Jul 13, 2020
@BartoszKlonowski
Copy link
Contributor

Blocked by #5539

@rozele
Copy link
Collaborator

rozele commented Oct 31, 2022 •
edited
Loading

Blocked by #5539

@BartoszKlonowski This is not technically blocked on the ABIViewManager limitations. Since this is a hoisted component anyway, you can inject a dummy FrameworkElement into the tree with Visibility set to None and attach the Flyout to the appropriate location via other props.

This is, however, blocked on missing public APIs for touch and keyboard event handling.

@chrisglein chrisglein mentioned this issue Jul 21, 2023
Open
15 tasks
@chrisglein
Copy link
Member Author

Not going to happen for Paper.
For Fabric, should track against #11921

@chiaramooney chiaramooney added the Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Flyout enhancement Extensions Tracks issues against community modules and extensions Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rozele @chrisglein @chiaramooney @BartoszKlonowski