Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout/Popup components for Fabric #11921

Open
15 tasks
Tracked by #12042
chrisglein opened this issue Jul 21, 2023 · 0 comments
Open
15 tasks
Tracked by #12042

Flyout/Popup components for Fabric #11921

chrisglein opened this issue Jul 21, 2023 · 0 comments
Assignees
Labels
Area: Fabric Support Facebook Fabric Area: Flyout Area: Modal Area: Popup enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone

Comments

@chrisglein
Copy link
Member

chrisglein commented Jul 21, 2023

Summary

On Paper, we have Flyout and Popup. Windows-only components, not part of RN core (and as such, not tracked here)

Notes from our discussion on "what to do with these on Fabric?":

  • We didn't do Modal because XAML's modal is very particular (e.g. ContentDialog one at at time). We will still need a lighter weight flyout that can still extend beyond window bounds. Note that this is a Desktop-centric scenario, not a Mobile-centric scenario, and may be more appropriate outside of RNW core.
  • We should find out what Messenger has done here. Office certainly has this scenario, but also has its own popup manager. We could try come up with a shared interface that meets the needs of these deep desktop apps and lets established needs like those of Office plug into an interface.
  • Unclear on what the core RN Modal mean as far as disabling non-RN UI for the app. Is it solving those hard problems? Modal · React Native. True input modality is hard.

See the tracking issue for Modal on Fabric

Related issues for E2E testing:
#11279
#11102

And the overall proposal (on Paper) of "should these live here?"
#4343

All this to say, we need to figure out what happens to Flyout/Popup on Fabric. Do they come over? If so, how do they change. If not, how can Modal/community cover what they solved?

Flyout

Assuming we kept the same API surface as our Paper implementation of Flyout (not a given), these are the APIs:

Popup

Assuming we kept the same API surface as our Paper implementation of Popup (not a given), these are the APIs:

Motivation

Migration of Paper apps to Fabric who used Flyout or Popup

Basic Example

@chrisglein chrisglein added this to the Backlog milestone Jul 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 21, 2023
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 31, 2023
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Fabric Support Facebook Fabric Area: Flyout Area: Modal Area: Popup enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
Status: No status
Development

No branches or pull requests

4 participants