-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the pit collector script #982
Conversation
hi, @SunsetWolf, in qlib/data/data.py 1166 line: try:
return DatasetD.dataset(
instruments, fields, start_time, end_time, freq, disk_cache, inst_processors=inst_processors
)
except TypeError:
return DatasetD.dataset(instruments, fields, start_time, end_time, freq, inst_processors=inst_processors) It will catch the |
Running this test requires initializing the calendar and instrument data.
|
Everything looks much simpler and cleaner than Qlib's initial version! |
* Optimize the pit collector script * Add copyright notice to collector.py * Remove unnecessary parameters for test_pit.py * Update test_pit.py * Update test_pit.py
Description
Optimize the pit collector script
Motivation and Context
I made a few changes to pit collector script:
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
PIT test results:
Types of changes