Modify set_global_logger_level use of contextmanager #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you-n-g
reviewed
May 12, 2021
qlib/log.py
Outdated
| @@ -165,8 +165,16 @@ def filter(self, record): | |||
| return allow | |||
|
|
|||
|
|
|||
| @contextmanager | |||
There was a problem hiding this comment.
@zhupr Please keep the previous set_global_logger_level function and create a new contextmanager.
I think they are both very useful.
Besides, please add detailed docstrings about the feature.
Thanks
you-n-g
reviewed
May 12, 2021
qlib/log.py
Outdated
| @@ -166,7 +166,79 @@ def filter(self, record): | |||
|
|
|||
|
|
|||
| def set_global_logger_level(level: int): | |||
There was a problem hiding this comment.
@zhupr You can add a parameter like return_orig_handler_level=False to control the return value to reuse this function in set_global_logger_level_contextmanager.
qlib/log.py
Outdated
|
|
||
|
|
||
| @contextmanager | ||
| def set_global_logger_level_contextmanager(level: int): |
There was a problem hiding this comment.
The function name is too long...
You can use a shorter name (e.g. use cm to replace contextmanger)
ffd33c9 to
76c5c5d
Compare
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
Modify set_global_logger_level use of contextmanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes