Fix errors when SignalRecord is not called before SigAna/PortAna #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derek-Wds
reviewed
Mar 16, 2021
qlib/workflow/record_temp.py
Outdated
| def generate(self, **kwargs): | ||
| try: | ||
| self.check(parent=True) | ||
| except: |
There was a problem hiding this comment.
Please specify the specific error type to avoid unexpected outcomes.
qlib/workflow/record_temp.py
Outdated
| self.check(parent=True) # "Make sure the parent process is completed and store the data properly." | ||
| try: | ||
| self.check(parent=True) # "Make sure the parent process is completed and store the data properly." | ||
| except: |
|
@D-X-Y LGTM. It's great |
|
Thanks for your instant review :) @you-n-g would you mind helping merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors when SignalRecord is not called before SigAna/PortAna and add unit tests.
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes