Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe yaml loader #273

Merged
merged 2 commits into from
Feb 18, 2021
Merged

safe yaml loader #273

merged 2 commits into from
Feb 18, 2021

Conversation

you-n-g
Copy link
Collaborator

@you-n-g you-n-g commented Feb 16, 2021

Description

For fixing 802dac8

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

you-n-g referenced this pull request Feb 16, 2021
@you-n-g
move freq params to dataloader
802dac8
@wphan
Copy link

wphan commented Feb 16, 2021

https://github.com/microsoft/qlib/search?q=yaml.load it looks like there are a couple more locations where yaml.load is used

@wphan
Copy link

wphan commented Feb 16, 2021

you might also want to use yaml.safe_load rather than setting the loader: https://pyyaml.org/wiki/PyYAMLDocumentation to be more explicit

@you-n-g
Copy link
Collaborator Author

you-n-g commented Feb 17, 2021

@vphan It is fixed now. Please check it :)

@you-n-g you-n-g merged commit 50d5fcf into microsoft:main Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@you-n-g @wphan