Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDG-DA] Update crowd-sourced data results #1405

Merged
merged 3 commits into from
Jan 2, 2023
Merged

[DDG-DA] Update crowd-sourced data results #1405

merged 3 commits into from
Jan 2, 2023

Conversation

wendili-cs
Copy link
Contributor

[DDG-DA] Update crowd-sourced data results

Description

Updating the experiment results on crowd-sourced data.

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 30, 2022
- The rolling time intervals are set to 20 trading days.
- The test rolling periods are from January 2017 to August 2020.
### Crowd Sourced Data
Here is the [crowd sourced version of qlib data](data_collector/crowd_source/README.md): https://github.com/chenditc/investment_data/releases
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reason why Qlib's public data is not used and this data-source is preferred.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Yahoo version of qlib data does not contain VWAP, so all related factors are missing and filled with 0, which leads to a singular matrix and makes lower-level optimization of DDG-DA can not be solved.

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 30, 2022

Please merge main branch to fix the CI.

The CI issue has been fixed in #1398

@you-n-g you-n-g merged commit ebb8ec3 into microsoft:main Jan 2, 2023
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* [DDG-DA] Update crowd-sourced data experiments

* Remove internal data version

* Modify README
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* [DDG-DA] Update crowd-sourced data experiments

* Remove internal data version

* Modify README
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* [DDG-DA] Update crowd-sourced data experiments

* Remove internal data version

* Modify README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants