Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typo in doc/comments #1389

Merged
merged 7 commits into from
Dec 11, 2022
Merged

Conversation

qianyun210603
Copy link
Contributor

Description

Fix some typo in doc/comments.
Resolve some lint warning.

Motivation and Context

improve code quality

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 11, 2022

Thanks for your contribution.
Please fix the CI error.
image

@qianyun210603
Copy link
Contributor Author

Thanks for your contribution. Please fix the CI error. image

A quick question please.
Why my black forces spaces before and after operator **
image
but the qlib CI forces no spaces? Do you have any clue that how my black should be configured to be consistent with CI? Or it's version inconsistency?

Thanks!

@you-n-g
Copy link
Collaborator

you-n-g commented Dec 11, 2022

@qianyun210603 I think this is a problem with the black version.
You can pip install -U black to upgrade your black to check if it works.

@you-n-g you-n-g merged commit 5e3924d into microsoft:main Dec 11, 2022
@you-n-g
Copy link
Collaborator

you-n-g commented Dec 11, 2022

It looks great now.
Thanks

@qianyun210603 qianyun210603 deleted the qy_docstring branch December 16, 2022 05:08
@you-n-g you-n-g added the documentation Improvements or additions to documentation label Jan 29, 2023
qianyun210603 added a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix typo in docstrings

* fix typo

* fix typo

* fix black lint

* fix black lint
qianyun210603 added a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix typo in docstrings

* fix typo

* fix typo

* fix black lint

* fix black lint
qianyun210603 added a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
* fix typo in docstrings

* fix typo

* fix typo

* fix black lint

* fix black lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants