Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REG_US and REG_TW into test case: test_utils.py. #1310

Merged
merged 9 commits into from
Oct 14, 2022
Merged

Add REG_US and REG_TW into test case: test_utils.py. #1310

merged 9 commits into from
Oct 14, 2022

Conversation

ChiahungTai
Copy link
Collaborator

Description

Add REG_US and REG_TW into test case: test_utils.py.

Motivation and Context

The original test is only for REG_CN. Add more test cases for other REG.

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/misc/test_utils.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@ChiahungTai
Copy link
Collaborator Author

@you-n-g Is this still the CI bug?
The pylint IIUC is only on qlib folder. My commit is for tests folder. Should not trigger this error.
Also the pylint work fine in my loacl.
See below:
Screen Shot 2022-10-09 at 12 02 43 PM

@ChiahungTai
Copy link
Collaborator Author

@you-n-g
How to fix it?
Any suggestion to how to pass the pylint?

Screen Shot 2022-10-12 at 4 32 14 PM

@you-n-g
Copy link
Collaborator

you-n-g commented Oct 14, 2022

Your reported CI issue has been fixed in this PR #1310
But there are some other issues to be fixed for the CI .
Please pay attention to this PR.
Thanks

@you-n-g
Copy link
Collaborator

you-n-g commented Oct 14, 2022

LGTM.
Let's merge it.
Then we'll fix the CI on the main branch.

@you-n-g you-n-g merged commit 84e9df2 into microsoft:main Oct 14, 2022
@ChiahungTai
Copy link
Collaborator Author

Your reported CI issue has been fixed in this PR #1310 But there are some other issues to be fixed for the CI . Please pay attention to this PR. Thanks

Thanks for your review. That will be great if you can notify me if the CI is stable.
After that, I will continue to contribute the codes.
:)

@you-n-g
Copy link
Collaborator

you-n-g commented Oct 14, 2022

Sure.
It seems that Git Actions has started to restrict the memory usage of testing.
So previous CI fails...
We are trying to reduce the memory usage of our tests.

@ChiahungTai
Copy link
Collaborator Author

Thanks for the response. That make sense. Time to cost down when the economic going down..... :(

@you-n-g you-n-g added the enhancement New feature or request label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
Add REG_US and REG_TW into test case: test_utils.py. (microsoft#1310)
7e6655d 
* Add REG_US and REG_TW into test case: test_utils.py.

* Fix black.

* Trigger checks.

* Add REG_US and REG_TW into test case: test_utils.py.

* Fix black.

* Trigger checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiahungTai @you-n-g