Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _update_dealt_order_amount bug. #1291

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Fix _update_dealt_order_amount bug. #1291

merged 2 commits into from
Sep 14, 2022

Conversation

lihuoran
Copy link
Contributor

Fix the bug in SimulatorExecutor._collect_data. Maintain self.dealt_order_amount before dealing with the order.

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@lihuoran lihuoran requested a review from you-n-g September 14, 2022 01:44
@you-n-g you-n-g merged commit 7c64ea5 into main Sep 14, 2022
@you-n-g you-n-g deleted the fix_dealt_order_amount_bug branch September 14, 2022 06:14
@you-n-g you-n-g added the bug Something isn't working label Dec 9, 2022
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@lihuoran
Fix _update_dealt_order_amount bug. (microsoft#1291)
cacaae7 
* Fix bug

* A weird Mypy issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g Awaiting requested review from you-n-g

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihuoran @you-n-g