update cli.py #1008
Merged
update cli.py #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file.
|
Hi, thank you for submitting PR, now, your PR didn't pass the CI test, I think to solve this problem, you can try to use black formatting code. |
|
Hi @SunsetWolf , Thanks for the suggestions. I tried to use black on cli.py. But the checks were still not successful. Can you please look into it and let me know what was wrong? Thanks! |
To solve this problem, we added the pre-commit hook to qlib, and you can check the fourth article of the developer documentation to learn how to use it. |
|
Besides, you can checkout the error information here |
|
It looks great! |
qianyun210603
pushed a commit
to qianyun210603/qlib
that referenced
this pull request
Mar 23, 2023
* update cli.py update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file. * black cli.py * Resolving pre-commit-hook changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update cli.py so that one can specify exp_manager uri in "qlib_init" and "experiment_name" in *.yaml file.
Description
In current workflow, the experiment manager uri will be overridden by the default in cli.py. This update allows the user to specify the uri.
Also, one can specify the experiment_name in yaml file.
Motivation and Context
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Screenshots of Test Results (if appropriate):
Types of changes