-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PRef operator (#988) #1000
Add PRef operator (#988) #1000
Conversation
Hi, @Chaoyingz I come up with another idea to make it implemented with less code ( Looking forward to your comments about it |
Hi, @you-n-g |
@Chaoyingz
We are trying to introduce minimal complexity (fewer methods, fewer arguments in the interface) into the framework when adding new features. And I come up with another option just now. How about adding a subclass for I think all the above solutions are good enough. You can choose the one you like :) |
fabdebd
to
7bc8426
Compare
@you-n-g I think the next step should be to adjust |
Hi, @Chaoyingz I think your next step looks very reasonable. |
@you-n-g 👌 |
It looks great! |
* Add PRef operator (microsoft#988) * Fix type annotations * Add test_pref_operator test case field * Add note to PITProvider * Add period parameter comment
Description
Added
PRef
operator to support querying pit data for a specified reporting period.Motivation and Context
See #988 .
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Types of changes