This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Fix Goto Definition with class methods #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2018 11:43
| return result; | ||
| } | ||
| private IEnumerable<IReferenceable> GetDefinitions(string name, IEnumerable<AnalysisValue> nses) | ||
| => nses.OfType<IReferenceableContainer>().SelectMany(c => c.GetDefinitions(name)); |
There was a problem hiding this comment.
What those subType.Push() and subType.Pop() has been doing?
There was a problem hiding this comment.
There is static hashset that tracks that the type is already being processed. I guess to prevent stack overflows with circular references. In this case, however, GetDefinition will add the type, otherwise, if added here, GetDefinition will return nothing since it will think type is processed up the call stack.
AlexanderSher
approved these changes
Oct 13, 2018
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fix Goto Definition with class methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225
Fixes #208
GetDefinition(name, types)on bases does not need to push type since it calls mainGetDefinition(name)which will push it. Pushing in the inner function prevents the outer from finding bases.