This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Prefer stub content when stub is available #1845
Open
MikhailArkhipov
wants to merge
136
commits into
microsoft:master
Choose a base branch
from
MikhailArkhipov:stubs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove readonly
Remove readonly
…etes presions analysis session that was canceled may still be running.
How does this work with partial stubs? Our typeshed is still an old copy (missing 3.8 stuff), and we bundle small targeted stubs for numpy. Does this only apply for stubs shipped directly with libraries? |
Change is limited to typeshed modules only. Numpy is not there so it is analyzed same way as before. Only stubs from typeshed are considered. |
Regular on
with
|
import sys
import os
import datetime Regular:
with
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1821
Prefer stub content when stub is available. Don't eval content beyond documentation. Increases analysis speed 20-50% depending on how many stubs are available.