This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Added handling of unhandled exception generated when VS Code disconnects #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detaching from a VSCode debug session via localhost:3000 on Windows 10 using the debug 'disconnect' button results in an unhandled exception in wrapper.py.
The specific unhandled error is errno.ECONNRESET (10054)
When this exception is not handled correctly, the instance of ptvsd becomes unresponsive and does not allow the debugger to connect again.
Notes:
This change fixes this issue but I can see that convert_eof() in socket.py should be handling this error and raising an EOFError exception - but for some reason it's not and a socket.error with errno == 10054 is raised instead.