This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Attach to pid fixes with threading. Fixes #1542,#1520 #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the build to have gdb. |
|
With the latest run. Linux passes, windows 2.7 is the flask issue. |
|
Just merged the temp fix for the flask issue. |
src/ptvsd/_vendored/pydevd/pydevd_attach_to_process/windows/attach.cpp
Outdated
Show resolved
Hide resolved
src/ptvsd/_vendored/pydevd/pydevd_attach_to_process/windows/attach.cpp
Outdated
Show resolved
Hide resolved
8e166cc to
efe292c
Compare
int19h
approved these changes
Jul 12, 2019
karthiknadig
approved these changes
Jul 12, 2019
I just did another change to improve that (so, if it passes I'll merge to master). |
|
All green 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a note, Linux (on Azure) is failing because there's no gdb and I'm not exactly sure how to do that on Azure (see: https://github.com/microsoft/ptvsd/pull/1582/files#diff-354f30a63fb0907d4ad57269548329e3R12 for the changes needed to run on travis -- i.e.: install gdb and set the
ptrace_scopeto0).I'm currently taking a look at the failures on Python 2.7 (windows and mac), so, this still can't be merged.