This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Pass 'removed' instead of 'remove' to on_breakpoints_changed. #1118 #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be causing a hang in MacOS 2.7 tests. but if I take the bigger change it seems to be fine. Is there any change that I must get along with this? |
|
Not really, just this change should be Ok and I think the issue is some case which is already flaky on master (the given change only affects removing breakpoints and as far as I can tell the test which is timing out doesn't remove any breakpoint). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1118