Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional batch_size to BatchAnalyzer.analyze_iterator #883

Closed
wants to merge 11 commits into from

Conversation

evgri243
Copy link

Change Description

Describe your changes

Issue reference

This PR fixes issue #882

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@evgri243 evgri243 changed the title Evgri243/add batch size Add optional batch_size to BatchAnalyzer.analyze_iterator Jun 23, 2022
@navalev
Copy link
Contributor

navalev commented Jun 23, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a few type hint suggestions

@omri374
Copy link
Contributor

omri374 commented Jun 27, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Jun 27, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

omri374
omri374 previously approved these changes Jun 27, 2022
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! great contribution

@omri374 omri374 requested review from navalev and shiranr June 27, 2022 11:40
@omri374
Copy link
Contributor

omri374 commented Jul 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)
Small comments

@evgri243 evgri243 requested a review from shiranr July 6, 2022 15:57
Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small comments

@omri374
Copy link
Contributor

omri374 commented Dec 18, 2022

@evgri243 this PR is very close to being ready. Would you be interested in merging it? Can we help in any way?

@avi-ko
Copy link

avi-ko commented Mar 21, 2023

Hi @omri374 @evgri243 ,
Is there a chance of merging this PR? 🙏

@omri374
Copy link
Contributor

omri374 commented Feb 3, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Feb 4, 2025

Continuing this PR in #1521

@omri374 omri374 closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants