Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): clarify connection method via BrowserType.connect #34560

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 30, 2025

BrowserType.connect usage was very unclear on how to use. Clarify this.

@agg23 agg23 requested a review from dgozman January 30, 2025 19:05
docs/src/api/class-browsertype.md Outdated Show resolved Hide resolved
docs/src/api/class-browsertype.md Outdated Show resolved Hide resolved
docs/src/api/class-browsertype.md Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
❌ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18

12 flaky ⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1100:1 › should serve overridden request @chromium-ubuntu-22.04-node20
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:278:14 › element screenshot › should restore viewport after page screenshot and exception @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/signals.spec.ts:25:5 › should close the browser when the node process closes @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37723 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

mxschmitt added a commit to mxschmitt/playwright that referenced this pull request Feb 3, 2025
mxschmitt added a commit that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
agg23 added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
agg23 added a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants