chore: get rid of rimraf package #27790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
adc3ceb to
e4ee421
Compare
e4ee421 to
7ea070b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Does it fix the bug? |
Yes see #27712 (comment) for investigation notes. rinraf was useful before Node.js had it built-in. |
This comment has been minimized.
This comment has been minimized.
dgozman
approved these changes
Oct 26, 2023
| @@ -245,7 +245,7 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun | |||
| options.log(`[pid=${spawnedProcess.pid || 'N/A'}] starting temporary directories cleanup`); | |||
| for (const dir of options.tempDirectories) { | |||
| try { | |||
| rimraf.sync(dir); | |||
| fs.rmSync(dir, { force: true, recursive: true, maxRetries: 10 }); | |||
There was a problem hiding this comment.
I wonder how does the sync version retry? Perhaps we should limit the number of retries here, say to 5, because max total time is quadratic?
mxschmitt
commented
Oct 26, 2023
Signed-off-by: Max Schmitt <max@schmitt.mx>
mxschmitt
commented
Oct 26, 2023
Signed-off-by: Max Schmitt <max@schmitt.mx>
mxschmitt
commented
Oct 26, 2023
This comment has been minimized.
This comment has been minimized.
mxschmitt
commented
Oct 26, 2023
Signed-off-by: Max Schmitt <max@schmitt.mx>
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 8 flaky25986 passed, 604 skipped Merge workflow run. |
Germandrummer92
pushed a commit
to OctoMind-dev/playwright
that referenced
this pull request
Oct 27, 2023
This seems more reliable nowadays as rimraf. microsoft#27712 --------- Signed-off-by: Max Schmitt <max@schmitt.mx>
itchyny
reviewed
Nov 20, 2023
| export async function removeFolders(dirs: string[]): Promise<Error[]> { | ||
| return await Promise.all(dirs.map((dir: string) => | ||
| fs.promises.rm(dir, { recursive: true, force: true, maxRetries: 10 }) | ||
| )).catch(e => e); |
There was a problem hiding this comment.
This looks like a mistake of .catch(e => e)));, i.e. should catch each error of fs.promises.rm. Otherwise the return type should be Promise<Error>.
There was a problem hiding this comment.
const fs = require('fs');
const dirs = ['/tmp/x', '/tmp/y'];
(async () => {
await Promise.all(dirs.map((dir) => Promise.reject({ dir }))).catch(e => e).then(x => console.log(x));
// { dir: '/tmp/x' }
await Promise.all(dirs.map((dir) => Promise.reject({ dir }).catch(e => e))).then(x => console.log(x));
// [ { dir: '/tmp/x' }, { dir: '/tmp/y' } ]
})();
There was a problem hiding this comment.
As a result, the following line of packages/playwright/src/runner/tasks.ts yields TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)).
await Promise.all(Array.from(outputDirs).map(outputDir => removeFolders([outputDir]).then(async ([error]) => {
There was a problem hiding this comment.
Good catch, are you interested in contributing a fix?
There was a problem hiding this comment.
Yes of course, I opened a pull request: #28239.
mxschmitt
pushed a commit
to mxschmitt/playwright
that referenced
this pull request
Nov 20, 2023
This PR fixes microsoft#27790 (review). Previously this function returns only the first error when some of the promises fail. But the type annotation suggests that the original intention was to collect all the errors. This commit fixes the error values, and unexpected `TypeError: object is not iterable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems more reliable nowadays as rimraf.
#27712