Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change debug_alloc to not exit(-1) so that our build tests pass #37

Merged
merged 3 commits into from
Nov 28, 2018

Conversation

RyanUnderhill
Copy link
Member

There is no actual memory leak in the shipping code, but there is a leak when run in our build tests due to sync_api.h using the Windows ThreadPool APIs directly.

When the ThreadPool APIs are used directly, 'static thread_local' variables don't get cleaned up on thread exit. std::async must be used to do proper cleanup.

raymondxyang
raymondxyang previously approved these changes Nov 28, 2018
@raymondxyang raymondxyang merged commit c07b4af into master Nov 28, 2018
@raymondxyang raymondxyang deleted the ryanunderhill/hide_leak branch November 28, 2018 00:40
tmccrmck added a commit to tmccrmck/onnxruntime that referenced this pull request Aug 28, 2019
…ster3

Merge upstream master again to settle merge conflicts
natke referenced this pull request in natke/onnxruntime Feb 15, 2022
* Docx updated for OpenVINO EP Samples

Updated docx which went missing during porting

Added new yolov4 sample code files and it's docx

Signed-off-by: MaajidKhan <n.maajidkhan@gmail.com>

* Removed unwanted headers from the docx

Signed-off-by: MaajidKhan <n.maajidkhan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants