-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React Native to 0.73 #23575
base: main
Are you sure you want to change the base?
Upgrade React Native to 0.73 #23575
Conversation
…-andriod-e2e-test-job.yml
# Conflicts: # js/react_native/e2e/android/gradle.properties # js/react_native/e2e/android/settings.gradle # js/react_native/e2e/ios/OnnxruntimeModuleExample.xcodeproj/project.pbxproj # js/react_native/e2e/ios/Podfile # js/react_native/e2e/ios/PrivacyInfo.xcprivacy # js/react_native/e2e/package.json # js/react_native/ios/OnnxruntimeModule.xcodeproj/project.pbxproj # js/react_native/ios/Podfile # js/react_native/ios/PrivacyInfo.xcprivacy # js/react_native/package.json
…natvie-andriod-e2e-test-job.yml
# Conflicts: # js/react_native/e2e/android/app/src/debug/java/com/example/reactnativeonnxruntimemodule/ReactNativeFlipper.java # js/react_native/e2e/android/build.gradle # js/react_native/e2e/android/gradle.properties # js/react_native/e2e/android/gradle/wrapper/gradle-wrapper.properties # js/react_native/e2e/package.json # js/react_native/e2e/yarn.lock # js/react_native/package.json # js/react_native/yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been converted into Kotlin as js/react_native/e2e/android/app/src/main/java/com/reactnativeonnxruntimemodule/MainActivity.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has been converted into Kotlin as
js/react_native/e2e/android/app/src/main/java/com/reactnativeonnxruntimemodule/MainApplication.kt
@@ -1,7 +1,7 @@ | |||
// Copyright (c) Microsoft Corporation. All rights reserved. | |||
// Licensed under the MIT License. | |||
|
|||
package com.example.reactnativeonnxruntimemodule; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the package name make it consistent with examples from ReactNative offical
@@ -1,7 +1,7 @@ | |||
// Copyright (c) Microsoft Corporation. All rights reserved. | |||
// Licensed under the MIT License. | |||
|
|||
package com.example.reactnativeonnxruntimemodule; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the package name make it consistent with examples from ReactNative offical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted from js/react_native/e2e/android/app/src/main/java/com/example/reactnativeonnxruntimemodule/MainActivity.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted from
js/react_native/e2e/android/app/src/main/java/com/example/reactnativeonnxruntimemodule/MainApplication.java
….openInputStream(Uri.parse(uri)); to reactContext.getContentResolver().openInputStream(Uri.parse(uri));
….openInputStream(Uri.parse(uri)); to reactContext.getContentResolver().openInputStream(Uri.parse(uri));
js/react_native/babel.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is no longer needed by RN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it have been migrated to Kotlin file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it have been migrated to Kotlin file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now recommended way to load a ReactPacakge after RN 0.72+
js/react_native/e2e/babel.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is on longer needed by RN
Description
Upgrading RN to 0.73.11, including Android and iOS changes.. This PR also include the E2E test changes.
Used React-Native upgrade helper as the reference.
Motivation and Context
Need newer RN version to fix S360 work items.