-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Native WebGPU EP] Add packedQKV and do_rotary attribute support to GroupQueryAttention operator #23386
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
…sajandhy/webpu-ep-gqa-rotary
…sajandhy/webpu-ep-gqa-rotary
…sajandhy/webpu-ep-gqa-rotary
… to initialize pos_ids to zeros for the first prompt.
… instead of the shader code.
…sajandhy/webpu-ep-gqa-rotary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
this needs to be merged with main to resolve some conflicts with fa2 and we need to add a condition to not call fa2. something like: if (!do_rotary_ && CanApplyFlashAttention |
Description
Add Packed QKV inputs and do_rotary attribute to GQA.
Motivation and Context
Packed QKV inputs and do_rotary attribute are required for certain models.