Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM CPU] Fix flaky hqnbitgemm UT #23010

Merged
merged 2 commits into from
Dec 4, 2024
Merged

[ARM CPU] Fix flaky hqnbitgemm UT #23010

merged 2 commits into from
Dec 4, 2024

Conversation

fajin-corp
Copy link
Contributor

Description

Increase fp16 qnbitgemm UT tol and use fixed seeds.

Motivation and Context

Copy link
Contributor

@fs-eire fs-eire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I didn't know there are random generated numbers used in test case, so this may be the cause of the randome test failure.

@fajin-corp fajin-corp merged commit fbe22fd into main Dec 4, 2024
95 checks passed
@fajin-corp fajin-corp deleted the fajin/qnbitgemm_fp16_ut branch December 4, 2024 22:55
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
Increase fp16 qnbitgemm UT tol and use fixed seeds.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
Increase fp16 qnbitgemm UT tol and use fixed seeds.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
Increase fp16 qnbitgemm UT tol and use fixed seeds.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
tarekziade pushed a commit to tarekziade/onnxruntime that referenced this pull request Jan 10, 2025
### Description
Increase fp16 qnbitgemm UT tol and use fixed seeds.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants