Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22890 Fix profiling on empty Optional #22891

Merged

Conversation

amancini-N
Copy link
Contributor

Description

Fix sequential_executor.cc to avoid segfault when profiling is used on model with empty Optional

Motivation and Context

Fixes #22890

@amancini-N
Copy link
Contributor Author

@amarin16 just a double check if I need to do anything before getting this merged, thx!

@amarin16
Copy link
Collaborator

I believe that the only thing remaining is to have all the pipelines pass

@amarin16
Copy link
Collaborator

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@amarin16
Copy link
Collaborator

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows ARM64 QNN CI Pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, Windows x64 QNN CI Pipeline, Linux MIGraphX CI Pipeline, Big Models

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@amarin16
Copy link
Collaborator

/azp run ONNX Runtime React Native CI Pipeline, orttraining-amd-gpu-ci-pipeline, Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@amarin16 amarin16 merged commit 8826e39 into microsoft:main Nov 26, 2024
84 checks passed
@amancini-N amancini-N deleted the 22890-fix-profiling-with-optional branch November 27, 2024 10:22
guschmue pushed a commit that referenced this pull request Dec 2, 2024
### Description
Fix sequential_executor.cc to avoid segfault when profiling is used on
model with empty Optional



### Motivation and Context
Fixes #22890
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
Fix sequential_executor.cc to avoid segfault when profiling is used on
model with empty Optional



### Motivation and Context
Fixes microsoft#22890
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
Fix sequential_executor.cc to avoid segfault when profiling is used on
model with empty Optional



### Motivation and Context
Fixes microsoft#22890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling profiler with empty Optional causes segmentation fault
2 participants