Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN] Fix MLTensorUsage is undefined issue #22831

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[WebNN] Fix MLTensorUsage is undefined issue #22831

merged 1 commit into from
Nov 14, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Nov 14, 2024 •
edited
Loading

MLTensorUsage has been removed from Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/6015318, but we still need to make it compatible with old Chrome versions, so just make it undefined for latest Chrome version.

@Honry
Copy link
Contributor Author

Honry commented Nov 14, 2024

@fdwr, @guschmue, PTAL, thanks!

@fdwr fdwr mentioned this pull request Nov 14, 2024
Closed
fdwr
fdwr previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr fdwr mentioned this pull request Nov 14, 2024
Merged
@Honry Honry force-pushed the remove-ml-tensor-usage branch from 230b2fa to 1a77cab Compare November 14, 2024 02:01
@Honry Honry changed the title [WebNN] Remove MLTensorUsage [WebNN] Fix MLTensorUsage is undefined issue Nov 14, 2024
fdwr
fdwr approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Honry
Copy link
Contributor Author

Honry commented Nov 14, 2024

@fdwr, @huningxin, PR updated and PTAL again, thanks!

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 14, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fdwr fdwr merged commit 8268120 into microsoft:main Nov 14, 2024
50 checks passed
@ibelem ibelem mentioned this pull request Nov 14, 2024
Merged
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@Honry
[WebNN] Fix MLTensorUsage is undefined issue (microsoft#22831)
f2ef7ad 
`MLTensorUsage` has been removed from Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/6015318, but
we still need to make it compatible with old Chrome versions, so just
make it `undefined` for latest Chrome version.
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@Honry @guschmue
[WebNN] Fix MLTensorUsage is undefined issue (#22831)
457d085 
`MLTensorUsage` has been removed from Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/6015318, but
we still need to make it compatible with old Chrome versions, so just
make it `undefined` for latest Chrome version.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@Honry @ankitm3k
[WebNN] Fix MLTensorUsage is undefined issue (microsoft#22831)
487cc92 
`MLTensorUsage` has been removed from Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/6015318, but
we still need to make it compatible with old Chrome versions, so just
make it `undefined` for latest Chrome version.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@Honry @ankitm3k
[WebNN] Fix MLTensorUsage is undefined issue (microsoft#22831)
1f5e077 
`MLTensorUsage` has been removed from Chromium:
https://chromium-review.googlesource.com/c/chromium/src/+/6015318, but
we still need to make it compatible with old Chrome versions, so just
make it `undefined` for latest Chrome version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin left review comments

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @fdwr @huningxin