Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN] Fixed WebNN Module undefined issue #22795

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[WebNN] Fixed WebNN Module undefined issue #22795

merged 2 commits into from
Nov 12, 2024

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Nov 11, 2024

Module.jsepRegisterMLConstant will be shorten by Closure Compiler in offical release, this would cause undefined error.

Fix it by using Module['jsepRegisterMLConstant'].

@Honry
[WebNN] Fixed WebNN Module undefiend issue
a38dedf 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler
in offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
@Honry
Copy link
Contributor Author

Honry commented Nov 11, 2024

@fs-eire, @fdwr, @guschmue, PTAL, thanks!

@ibelem ibelem mentioned this pull request Nov 11, 2024
Merged
@fdwr fdwr changed the title [WebNN] Fixed WebNN Module undefiend issue [WebNN] Fixed WebNN Module undefined issue Nov 11, 2024
fdwr
fdwr previously approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍@fs-eire and Guenther know this aspect better, but LGTM.

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

Error: Following source files are not formatted: (did you run "npm run format"?)
js/web/lib/wasm/wasm-types.ts

@Honry
Copy link
Contributor Author

Honry commented Nov 12, 2024

Error: Following source files are not formatted: (did you run "npm run format"?) js/web/lib/wasm/wasm-types.ts

@fdwr, my bad, fix in new commit, PTAL again, thanks!

fdwr
fdwr approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@ibelem ibelem mentioned this pull request Nov 12, 2024
Merged
@fdwr fdwr merged commit cdc8db9 into microsoft:main Nov 12, 2024
75 checks passed
@guschmue guschmue added the ep:WebNN WebNN execution provider label Nov 12, 2024
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@Honry
[WebNN] Fixed WebNN Module undefined issue (microsoft#22795)
883a8e7 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler in
offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@Honry @guschmue
[WebNN] Fixed WebNN Module undefined issue (#22795)
6088ae8 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler in
offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@Honry @ankitm3k
[WebNN] Fixed WebNN Module undefined issue (microsoft#22795)
cbf7b01 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler in
offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@Honry @ankitm3k
[WebNN] Fixed WebNN Module undefined issue (microsoft#22795)
d0bf675 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler in
offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@Honry @ankitm3k
[WebNN] Fixed WebNN Module undefined issue (microsoft#22795)
cc89112 
`Module.jsepRegisterMLConstant` will be shorten by Closure Compiler in
offical release, this would cause undefined error.

Fix it by using `Module['jsepRegisterMLConstant']`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
ep:WebNN WebNN execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Honry @fdwr @guschmue