Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Support LRN operator #22775

Merged
merged 3 commits into from
Nov 12, 2024
Merged

[WebNN EP] Support LRN operator #22775

merged 3 commits into from
Nov 12, 2024

Conversation

miaobin
Copy link
Contributor

@miaobin miaobin commented Nov 8, 2024

WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow -> div
@Honry @fdwr PTAL, thanks!

Honry
Honry reviewed Nov 8, 2024
View reviewed changes
@miaobin
Copy link
Contributor Author

miaobin commented Nov 11, 2024

Updated the code based on comments. Please take another look, thanks a lot! @Honry @fdwr

fdwr
fdwr reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Bin. ⭐

FYI @yassermkhan, new support for an ORT WebNN EP operator.

@miaobin
Copy link
Contributor Author

miaobin commented Nov 11, 2024 •
edited
Loading

Thank you for your patient review @Honry @fdwr . Updated the code and please take another look. Thanks a lot!

fdwr
fdwr approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Bin.

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 11, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr fdwr merged commit 67f5be0 into microsoft:main Nov 12, 2024
75 checks passed
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@miaobin
[WebNN EP] Support LRN operator (microsoft#22775)
0d78e91 
WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to
emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow
-> div
@Honry @fdwr PTAL, thanks!
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@miaobin @guschmue
[WebNN EP] Support LRN operator (#22775)
09b1531 
WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to
emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow
-> div
@Honry @fdwr PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Support LRN operator (microsoft#22775)
516fe3e 
WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to
emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow
-> div
@Honry @fdwr PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Support LRN operator (microsoft#22775)
533b3a2 
WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to
emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow
-> div
@Honry @fdwr PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Support LRN operator (microsoft#22775)
d05f287 
WebNN doesn't provide dedicate op for LRN, use a couple of WebNN ops to
emulate it in WebNN EP:
pow -> transpose -> pad -> averagePool -> transpose -> mul -> add -> pow
-> div
@Honry @fdwr PTAL, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin left review comments

@fdwr fdwr fdwr approved these changes

@Honry Honry Honry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miaobin @fdwr @huningxin @Honry