Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MatMulBnFusion to exclude cases when tensors are not 2D tensors #22762

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Nov 7, 2024

Description

Fixes #22512, MatMul, Add can be fused into a single Gemm even if tensors dimensions are > 2. The PR excludes that cases.

Motivation and Context

ORT crashes on valid models due to that unexpected fusion.

@xadupre xadupre requested a review from tianleiwu November 10, 2024 17:10
tianleiwu
tianleiwu previously approved these changes Nov 11, 2024
@xadupre xadupre merged commit 1f3b675 into microsoft:main Nov 11, 2024
89 of 92 checks passed
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
…icrosoft#22762)

### Description
Fixes microsoft#22512, MatMul, Add can be fused into a single Gemm even if
tensors dimensions are > 2. The PR excludes that cases.



### Motivation and Context
ORT crashes on valid models due to that unexpected fusion.
guschmue pushed a commit that referenced this pull request Dec 2, 2024
…22762)

### Description
Fixes #22512, MatMul, Add can be fused into a single Gemm even if
tensors dimensions are > 2. The PR excludes that cases.



### Motivation and Context
ORT crashes on valid models due to that unexpected fusion.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
…icrosoft#22762)

### Description
Fixes microsoft#22512, MatMul, Add can be fused into a single Gemm even if
tensors dimensions are > 2. The PR excludes that cases.



### Motivation and Context
ORT crashes on valid models due to that unexpected fusion.
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
…icrosoft#22762)

### Description
Fixes microsoft#22512, MatMul, Add can be fused into a single Gemm even if
tensors dimensions are > 2. The PR excludes that cases.



### Motivation and Context
ORT crashes on valid models due to that unexpected fusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onnxruntime optimizers fails
2 participants