Replace gsl::narrow with narrow in WebNN code #22733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address issue #22712
|
/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CUDA CI Pipeline |
|
/azp run Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Azure Pipelines successfully started running 7 pipeline(s). |
|
/azp run onnxruntime-binary-size-checks-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
snnn
approved these changes
Nov 5, 2024
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
Replace use of `gsl::narrow` with `narrow` to build for WebNN @snnn ### Description Building for WebNN with exceptions disabled cannot use `gsl::narrow`. Replace with `narrow` ### Motivation and Context Address issue microsoft#22712
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
Replace use of `gsl::narrow` with `narrow` to build for WebNN @snnn ### Description Building for WebNN with exceptions disabled cannot use `gsl::narrow`. Replace with `narrow` ### Motivation and Context Address issue microsoft#22712
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
Dec 11, 2024
Replace use of `gsl::narrow` with `narrow` to build for WebNN @snnn ### Description Building for WebNN with exceptions disabled cannot use `gsl::narrow`. Replace with `narrow` ### Motivation and Context Address issue microsoft#22712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of
gsl::narrowwithnarrowto build for WebNN @snnnDescription
Building for WebNN with exceptions disabled cannot use
gsl::narrow. Replace withnarrowMotivation and Context
Address issue #22712