Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reference to python 3.8 with python 3.10 #22692

Merged
merged 19 commits into from
Nov 8, 2024
Merged

Replace reference to python 3.8 with python 3.10 #22692

merged 19 commits into from
Nov 8, 2024

Conversation

jchen351
Copy link
Contributor

@jchen351 jchen351 commented Nov 1, 2024

Description

This PR will set default python to 3.10 except tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require additional changes. Which will be track in
USER STORY 52729

Motivation and Context

@jchen351 jchen351 requested a review from a team as a code owner November 1, 2024 17:28
@jchen351 jchen351 changed the title Replace reference to python 3.8 with python 3.19 Replace reference to python 3.8 with python 3.10 Nov 1, 2024
@snnn
Copy link
Member

snnn commented Nov 1, 2024

Thanks for taking care of it.

Comment on lines 347 to 362
# def test_mul_precision(self):
# graph_input = onnx.helper.make_tensor_value_info("input", TensorProto.FLOAT, [1024])
# graph_output = onnx.helper.make_tensor_value_info("output", TensorProto.FLOAT, None)
#
# # initializers
# value = numpy.array([0.5], dtype=numpy.float32)
# constant = numpy_helper.from_array(value, name="constant")
#
# nodes = [
# # Get the shape of the input tensor: `input_tensor_shape = [1024]`.
# onnx.helper.make_node("Shape", ["input"], ["input_shape"]),
# # mul(1024, 0.5) => 512
# onnx.helper.make_node("Mul", ["input_shape", "constant"], ["output_shape"]),
# # Resize input
# onnx.helper.make_node(
# "Resize", inputs=["input", "", "", "output_shape"], outputs=["output"], mode="nearest"

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.
Comment on lines 372 to 387
# def test_div_precision(self):
# graph_input = onnx.helper.make_tensor_value_info("input", TensorProto.FLOAT, [768])
# graph_output = onnx.helper.make_tensor_value_info("output", TensorProto.FLOAT, None)
#
# # initializers
# value = numpy.array([1.5], dtype=numpy.float32)
# constant = numpy_helper.from_array(value, name="constant")
#
# nodes = [
# # Get the shape of the input tensor: `input_tensor_shape = [768]`.
# onnx.helper.make_node("Shape", ["input"], ["input_shape"]),
# # div(768, 1.5) => 512
# onnx.helper.make_node("Div", ["input_shape", "constant"], ["output_shape"]),
# # Resize input
# onnx.helper.make_node(
# "Resize", inputs=["input", "", "", "output_shape"], outputs=["output"], mode="nearest"

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.
@snnn snnn requested a review from yf711 November 5, 2024 04:20
# Conflicts:
#	onnxruntime/test/python/onnxruntime_test_python_symbolic_shape_infer.py
@jchen351 jchen351 merged commit e7987a6 into main Nov 8, 2024
91 checks passed
@jchen351 jchen351 deleted the Cjian/py38 branch November 8, 2024 00:51
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
### Description
This PR will set default python to 3.10 except
tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is
needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require
additional changes. Which will be track in
USER STORY 52729



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
guschmue pushed a commit that referenced this pull request Dec 2, 2024
### Description
This PR will set default python to 3.10 except
tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is
needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require
additional changes. Which will be track in
USER STORY 52729



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
This PR will set default python to 3.10 except
tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is
needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require
additional changes. Which will be track in
USER STORY 52729



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
This PR will set default python to 3.10 except
tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is
needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require
additional changes. Which will be track in
USER STORY 52729



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
### Description
This PR will set default python to 3.10 except
tools/ci_build/github/azure-pipelines/bigmodels-ci-pipeline.yml. This is
needed because we are no longer using python 3.8

This PR excludes changes for Big Models CI, because it will require
additional changes. Which will be track in
USER STORY 52729



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants