Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/webgpu] support GridSample operator #22652

Merged
merged 4 commits into from
Nov 8, 2024
Merged

[js/webgpu] support GridSample operator #22652

merged 4 commits into from
Nov 8, 2024

Conversation

xhcao
Copy link
Contributor

@xhcao xhcao commented Oct 30, 2024

Description

Motivation and Context

@xhcao
Copy link
Contributor Author

xhcao commented Oct 30, 2024

@qjia7 @gyagp Please take a look, thanks. #22425

qjia7
qjia7 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

You may also need to trigger node generate-webgpu-operator-md.js under script to update js/web/docs/webgpu-operators.md

@qjia7
Copy link
Contributor

qjia7 commented Nov 4, 2024

Add @guschmue @fs-eire review, thanks.

@Dexterp37
Copy link

Hey @xhcao (and @qjia7 !), thank you for your efforts on this! Is there any timeline for merging it?

@xhcao
Copy link
Contributor Author

xhcao commented Nov 8, 2024

Hey @xhcao (and @qjia7 !), thank you for your efforts on this! Is there any timeline for merging it?

Hi, @Dexterp37 It could be merged after @guschmue and @fs-eire review and approve it.

@Dexterp37
Copy link

Hey @xhcao (and @qjia7 !), thank you for your efforts on this! Is there any timeline for merging it?

Hi, @Dexterp37 It could be merged after @guschmue and @fs-eire review and approve it.

Got it! I don't see either of them in the reviewer's list in the top-right, but given this message I'm not sure who should be adding them

@guschmue
Copy link
Contributor

guschmue commented Nov 8, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Nov 8, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@guschmue
Copy link
Contributor

guschmue commented Nov 8, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@guschmue
Copy link
Contributor

guschmue commented Nov 8, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Nov 8, 2024
@guschmue guschmue merged commit b5ee4ac into microsoft:main Nov 8, 2024
50 checks passed
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@xhcao
[js/webgpu] support GridSample operator (microsoft#22652)
6cb1b60 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@xhcao @guschmue
[js/webgpu] support GridSample operator (#22652)
b9c572b 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@xhcao @ankitm3k
[js/webgpu] support GridSample operator (microsoft#22652)
620e50e 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@xhcao @ankitm3k
[js/webgpu] support GridSample operator (microsoft#22652)
ae95257 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@xhcao @ankitm3k
[js/webgpu] support GridSample operator (microsoft#22652)
9cdff53 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjia7 qjia7 qjia7 approved these changes

@guschmue guschmue guschmue approved these changes

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhcao @qjia7 @Dexterp37 @guschmue