-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Linux Github actions to a dedicated pool #22566
Conversation
python -m pip install -r requirements-dev.txt | ||
python -m pip install lintrunner lintrunner-adapters | ||
export PATH=$HOME/.local/bin:$PATH | ||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this was setting +e
but now is -e
. Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"exit on error" . Previously we worried about the stability ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intended to not exit on error, as the error code is emitted by the linter and is expected when there are lint messages. We need the next step to run to post the messages as suggestions. I fixed it in #22667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... I see. Sorry about that.
### Description Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow. ### Motivation and Context To speed up the running.
### Description Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow. ### Motivation and Context To speed up the running.
### Description Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow. ### Motivation and Context To speed up the running.
### Description Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow. ### Motivation and Context To speed up the running.
### Description Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow. ### Motivation and Context To speed up the running.
### Description - Update ORT version to 1.20.2 - Cherry-pick commits: - #23243 - #22738 - #22868 - #23281 - #22543 - #22566 - #23308 - #23017 - [Main feature] #23368 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> --------- Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: Tianlei Wu <tlwu@microsoft.com> Co-authored-by: Jian Chen <cjian@microsoft.com> Co-authored-by: Yi Zhang <zhanyi@microsoft.com> Co-authored-by: Caroline Zhu <wolfivyaura@gmail.com>
Description
Move Linux Github actions to a dedicated pool. Currently the "orttraining-linux-ci-pipeline " is too slow.
Motivation and Context
To speed up the running.