Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VitisAI] Cache node subgraph when necessary #22073

Merged
merged 16 commits into from
Nov 9, 2024
Merged

[VitisAI] Cache node subgraph when necessary #22073

merged 16 commits into from
Nov 9, 2024

Conversation

zz002
Copy link
Contributor

@zz002 zz002 commented Sep 12, 2024 •
edited
Loading

Description

[VitisAI] Cache node subgraph when necessary

Motivation and Context

@zz002 zz002 changed the title Fallback [VitisAI] Cache node subgraph when necessary Sep 14, 2024
@zz002 zz002 marked this pull request as ready for review September 14, 2024 05:26
@zz002
Copy link
Contributor Author

zz002 commented Sep 14, 2024

Hi @jywu-msft
A new feature in VitisAI. If you have a moment, could you please take a look at the code?

@zz002
Copy link
Contributor Author

zz002 commented Sep 24, 2024

hi @jywu-msft

@jywu-msft
Copy link
Member

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows x64 QNN CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@jywu-msft
Copy link
Member

change causes build breaks in several CI Pipelines

2024-09-24T05:31:02.5670130Z /mnt/vss/_work/1/s/onnxruntime/core/session/provider_bridge_ort.cc:1206:37: error: 'GraphViewer__GetSchemaRegistry' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
2024-09-24T05:31:02.5671904Z 1206 | IOnnxRuntimeOpSchemaCollectionPtr GraphViewer__GetSchemaRegistry(const GraphViewer* p) const { return p->GetSchemaRegistry(); }
2024-09-24T05:31:02.5672437Z | ^
2024-09-24T05:31:02.5736271Z /mnt/vss/_work/1/s/onnxruntime/core/providers/shared_library/provider_interfaces.h:996:45: note: overridden virtual function is here
2024-09-24T05:31:02.5737325Z 996 | virtual IOnnxRuntimeOpSchemaCollectionPtr GraphViewer__GetSchemaRegistry(const GraphViewer* p) const = 0;
2024-09-24T05:31:02.5737829Z |

@jywu-msft jywu-msft added the ep:VitisAI issues related to Vitis AI execution provider label Sep 24, 2024
@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows x64 QNN CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@jywu-msft
Copy link
Member

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@zz002
Copy link
Contributor Author

zz002 commented Oct 17, 2024

hi @jywu-msft

@zz002
Copy link
Contributor Author

zz002 commented Nov 8, 2024

hi @jywu-msft
Can this PR be considered for merging?

@jywu-msft
Copy link
Member

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Windows GPU CUDA CI Pipeline, Windows GPU DML CI Pipeline, Windows GPU Doc Gen CI Pipeline

@jywu-msft
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Linux QNN CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@jywu-msft
Copy link
Member

/azp run Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows x64 QNN CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@jywu-msft
Copy link
Member

/azp run orttraining-linux-ci-pipeline, Python format

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jywu-msft
Copy link
Member

/azp run Python format

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@jywu-msft jywu-msft closed this Nov 9, 2024
@jywu-msft jywu-msft reopened this Nov 9, 2024
@jywu-msft jywu-msft merged commit d3ad76b into microsoft:main Nov 9, 2024
73 checks passed
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@zz002
[VitisAI] Cache node subgraph when necessary (microsoft#22073)
6113cd7 
### Description
<!-- Describe your changes. -->

[VitisAI] Cache node subgraph when necessary

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

---------

Co-authored-by: Zhenze Wang <zhenzew@xilinx.com>
Co-authored-by: zhenzew <zhenzew@amd.com>
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@zz002 @guschmue
[VitisAI] Cache node subgraph when necessary (#22073)
21a37df 
### Description
<!-- Describe your changes. -->

[VitisAI] Cache node subgraph when necessary

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

---------

Co-authored-by: Zhenze Wang <zhenzew@xilinx.com>
Co-authored-by: zhenzew <zhenzew@amd.com>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@zz002 @ankitm3k
[VitisAI] Cache node subgraph when necessary (microsoft#22073)
73c77c8 
### Description
<!-- Describe your changes. -->

[VitisAI] Cache node subgraph when necessary

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

---------

Co-authored-by: Zhenze Wang <zhenzew@xilinx.com>
Co-authored-by: zhenzew <zhenzew@amd.com>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@zz002 @ankitm3k
[VitisAI] Cache node subgraph when necessary (microsoft#22073)
f3a106a 
### Description
<!-- Describe your changes. -->

[VitisAI] Cache node subgraph when necessary

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

---------

Co-authored-by: Zhenze Wang <zhenzew@xilinx.com>
Co-authored-by: zhenzew <zhenzew@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywu-msft jywu-msft jywu-msft approved these changes

Assignees
No one assigned
Labels
ep:VitisAI issues related to Vitis AI execution provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zz002 @jywu-msft