Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock migraphx and linux GPU training ci pipelines #21662

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Unblock migraphx and linux GPU training ci pipelines #21662

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b70960d
disable a test to unblock pipeline
tianleiwu Aug 7, 2024
e4d3507
fix migraphx ci pipeline
tianleiwu Aug 7, 2024
9420705
use torch for cuda 11.8
tianleiwu Aug 8, 2024
ee65ccc
torch==2.3.1+cu118 and disable test_aten_attention
tianleiwu Aug 8, 2024
080f05b
skip orttraining_ortmodule_distributed_tests.py
tianleiwu Aug 8, 2024
b255667
skip test_softmax_bf16_large
tianleiwu Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "migraphx_allocator.h"
#include "gpu_data_transfer.h"
#include "migraphx_inc.h"
#include <hip/hip_version.h>

Check warning on line 20 in onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc

View workflow job for this annotation

GitHub Actions / Optional Lint C++ 

[cpplint] reported by reviewdog 🐶
 Found C system header after other header. Should be: migraphx_execution_provider.h, c system, c++ system, other.  [build/include_order] [4]

Raw Output:
onnxruntime/core/providers/migraphx/migraphx_execution_provider.cc:20:  Found C system header after other header. Should be: migraphx_execution_provider.h, c system, c++ system, other.  [build/include_order] [4]

#include "migraphx_stream_handle.h"

Expand Down Expand Up @@ -1299,7 +1300,9 @@
if (!input_shape_match) {
if (!load_precompiled_model(prog, load_compiled_model_, std::string{load_compiled_path_})) {
LOGS_DEFAULT(VERBOSE) << "No Input shapes mismatch detected. Recompiling" << std::endl;
#if HIP_VERSION_MAJOR > 6 || (HIP_VERSION_MAJOR == 6 && HIP_VERSION_MINOR >= 2)
cmp_options.set_external_data_path(model_path_.has_parent_path() ? model_path_.parent_path().string() : std::filesystem::current_path().string());
#endif
prog = migraphx::parse_onnx_buffer(onnx_string, cmp_options);

// Read in the calibration data and map it to an migraphx paramater map for the calibration ops
Expand Down
4 changes: 4 additions & 0 deletions onnxruntime/test/onnx/TestCase.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,6 +1035,10 @@ std::unique_ptr<std::set<BrokenTest>> GetBrokenTests(const std::string& provider
// std::set<std::string> broken_tests_keyword_set = {};

if (provider_name == "cuda") {
#ifdef ENABLE_TRAINING_CORE
// cudnn frontend exception in orttraining-linux-gpu-ci-pipeline.
broken_tests->insert({"keras_lotus_resnet3D", "Temporarily disabled pending investigation", {}});
#endif
#ifdef _WIN32
broken_tests->insert({"LSTM_Seq_lens_unpacked", "this test fails with new image since Aug 25."});
broken_tests->insert({"bidaf", "this test fails with new image since Aug 25."});
Expand Down
2 changes: 2 additions & 0 deletions orttraining/orttraining/test/python/orttraining_test_ortmodule_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,8 @@ def run_step(model, rerouted_output, dispatch_mask, expert_output):
@pytest.mark.parametrize("input_requires_grad", [False, True])
@pytest.mark.parametrize("conv_algo_search", [None, "EXHAUSTIVE", "HEURISTIC"])
def test_gradient_correctness_conv1d(use_fp16, input_requires_grad, conv_algo_search):
pytest.skip("Temporarily disabled pending investigation (might be related to cudnn frontend).")

class NeuralNetConv1D(torch.nn.Module):
def __init__(self, in_channels, out_channels, kernel_size, padding=0, groups=1):
super().__init__()
Expand Down
4 changes: 2 additions & 2 deletions tools/ci_build/github/azure-pipelines/templates/orttraining-linux-gpu-test-ci-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ steps:
--volume $(Build.BinariesDirectory)/${{ parameters.BuildConfig }}:/build \
--volume $(Agent.TempDirectory)/mnist:/mnist \
${{ parameters.DockerImageTag }} \
bash -c "rm -rf /build/onnxruntime/ && python3 -m pip install /build/dist/onnxruntime*.whl && python3 -m onnxruntime.training.ortmodule.torch_cpp_extensions.install && /build/launch_test.py --cmd_line_with_args 'python orttraining_ortmodule_tests.py --mnist /mnist --bert_data /bert_data/hf_data/glue_data/CoLA/original/raw' --cwd /build" \
bash -c "rm -rf /build/onnxruntime/ && python3 -m pip show torch && python3 -m pip install torch --index-url https://download.pytorch.org/whl/cu118 --force-reinstall && python3 -m pip install /build/dist/onnxruntime*.whl && python3 -m onnxruntime.training.ortmodule.torch_cpp_extensions.install && /build/launch_test.py --cmd_line_with_args 'python orttraining_ortmodule_tests.py --mnist /mnist --bert_data /bert_data/hf_data/glue_data/CoLA/original/raw' --cwd /build" \
displayName: 'Run orttraining_ortmodule_tests.py'
condition: succeededOrFailed()
timeoutInMinutes: 60
Expand All @@ -35,7 +35,7 @@ steps:
--volume $(Build.SourcesDirectory):/onnxruntime_src \
--volume $(Build.BinariesDirectory)/${{ parameters.BuildConfig }}:/build \
${{ parameters.DockerImageTag }} \
bash -c "rm -rf /build/onnxruntime/ && python3 -m pip install /build/dist/onnxruntime*.whl && /build/launch_test.py --cmd_line_with_args 'python orttraining_test_ort_apis.py --cwd /build' --cwd /build" \
bash -c "rm -rf /build/onnxruntime/ && python3 -m pip install /build/dist/onnxruntime*.whl && python3 -m pip show torch && python3 -m pip install torch --index-url https://download.pytorch.org/whl/cu118 && /build/launch_test.py --cmd_line_with_args 'python orttraining_test_ort_apis.py --cwd /build' --cwd /build" \
displayName: 'Run ORT Training APIs Tests'
condition: succeededOrFailed()
timeoutInMinutes: 120
Loading