[QNN EP] Increase tolerance for ReduceProd test on x64 Windows #17078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HectorSVC Apparently this also happens on Linux x64. We didn't see it before because we were using "random" inputs, and the random inputs were different for Linux and Windows. Now that I added a test with fixed inputs, we see the inaccuracy for both Linux and Windows x64. |
jywu-msft
approved these changes
Aug 9, 2023
jchen351
pushed a commit
that referenced
this pull request
Aug 12, 2023
### Description Slightly increases the allowable error tolerance for ReduceProd tests on x64 Windows/Linux with the QNN CPU backend. ### Motivation and Context A recent [PR](#16916) updated the input range for ReduceProd tests, which uncovered an inaccuracy for ReduceProd on x64 Windows/Linux with the QNN CPU backend. This PR updates the allowable error tolerance and adds a TODO for investigation. This is needed to ensure the QNN_Nuget_Windows pipeline runs successfully.
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…soft#17078) ### Description Slightly increases the allowable error tolerance for ReduceProd tests on x64 Windows/Linux with the QNN CPU backend. ### Motivation and Context A recent [PR](microsoft#16916) updated the input range for ReduceProd tests, which uncovered an inaccuracy for ReduceProd on x64 Windows/Linux with the QNN CPU backend. This PR updates the allowable error tolerance and adds a TODO for investigation. This is needed to ensure the QNN_Nuget_Windows pipeline runs successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slightly increases the allowable error tolerance for ReduceProd tests on x64 Windows/Linux with the QNN CPU backend.
Motivation and Context
A recent PR updated the input range for ReduceProd tests, which uncovered an inaccuracy for ReduceProd on x64 Windows/Linux with the QNN CPU backend. This PR updates the allowable error tolerance and adds a TODO for investigation.
This is needed to ensure the QNN_Nuget_Windows pipeline runs successfully.