Add limit input rank <= 4 in NNAPI EP Sigmoid op support checker #13019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Sep 20, 2022
| @@ -80,6 +80,30 @@ TEST(NnapiExecutionProviderTest, ReshapeFlattenTest) { | |||
| #endif | |||
| } | |||
|
|
|||
| TEST(NnapiExecutionProviderTest, SigmoidSupportedInputRankTest) { | |||
| const ORTCHAR_T* model_file_name = ORT_TSTR("testdata/nnapi_sigmoid_input_rank_test.onnx"); | |||
|
|
|||
There was a problem hiding this comment.
Should this model be added to the PR?
There was a problem hiding this comment.
yes. sorry - got gitignored. added to the pr.
skottmckay
approved these changes
Sep 20, 2022
linnealovespie
pushed a commit
that referenced
this pull request
Sep 30, 2022
) **Description**: Describe your changes. As title. Added unit test for the case. **Motivation and Context** - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. Fix issue #12979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
As title.
Added unit test for the case.
Motivation and Context
Fix issue #12979