[ADD] add skip layernorm to kernel explorer for ROCm EP #12816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging eb047b5 into 3a55694 - view on LGTM.com new alerts:
|
justinchuby
reviewed
Sep 1, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Sep 1, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Outdated
Show resolved
Hide resolved
justinchuby
reviewed
Sep 1, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Show resolved
Hide resolved
cloudhan
reviewed
Sep 5, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Show resolved
Hide resolved
cloudhan
reviewed
Sep 5, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Outdated
Show resolved
Hide resolved
cloudhan
reviewed
Sep 5, 2022
This was referenced Sep 5, 2022
zhangyaobit
reviewed
Sep 16, 2022
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm.cc
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Outdated
Show resolved
Hide resolved
onnxruntime/python/tools/kernel_explorer/kernels/skip_layer_norm_test.py
Outdated
Show resolved
Hide resolved
b7fdf1e to
f0de88b
Compare
cloudhan
reviewed
Sep 19, 2022
zhangyaobit
previously approved these changes
Sep 19, 2022
795f9c1 to
4479445
Compare
cloudhan
approved these changes
Sep 20, 2022
PeixuanZuo
added a commit
that referenced
this pull request
Sep 23, 2022
**Description**: Describe your changes. Related PR: #12803 #12816 #12821 1.add tunable skip layernorm for rocm ep 2. keep origin implementation when disable tuning. **Motivation and Context** - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here.
linnealovespie
pushed a commit
that referenced
this pull request
Sep 30, 2022
**Description**: Describe your changes. Related PR: #12803 #12816 #12821 1.add tunable skip layernorm for rocm ep 2. keep origin implementation when disable tuning. **Motivation and Context** - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Related PR: #12803 #12817 #12821
Add skip layernorm to kernel explorer for profiling.
Motivation and Context