Skip to content

Commit

Permalink
update ifdef
Browse files Browse the repository at this point in the history
  • Loading branch information
edgchen1 committed Jan 30, 2025
1 parent 8ec8c05 commit 772037d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/onnxruntime/core/common/parse_string.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ namespace onnxruntime {
namespace detail {

// Whether we will use std::from_chars() to parse to `T`.
#if defined(__ANDROID__)
// Note: As of Android NDK r27c, std::from_chars() doesn't support floating point types.
#if defined(_LIBCPP_VERSION)
// Note: Currently (e.g., in LLVM 19), libc++'s std::from_chars() doesn't support floating point types yet.
template <typename T>
constexpr bool ParseWithFromChars = !std::is_same_v<bool, T> && std::is_integral_v<T>;
#else
Expand Down

0 comments on commit 772037d

Please sign in to comment.