Adding CUDNN Frontend and use for CUDA NN Convolution #32341
lint.yml
on: pull_request
Optional Lint
34s
Python format
3m 43s
Optional Lint C++
13m 50s
Lint JavaScript
28s
Annotations
1 error and 18 warnings
Optional Lint C++
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Optional Lint:
onnxruntime/core/providers/cuda/nn/conv.cc#L477
[misspell] reported by reviewdog 🐶
"succesful" is a misspelling of "successful"
Raw Output:
./onnxruntime/core/providers/cuda/nn/conv.cc:477:41: "succesful" is a misspelling of "successful"
|
Optional Lint:
onnxruntime/contrib_ops/cuda/fused_conv.cc#L201
[misspell] reported by reviewdog 🐶
"expecially" is a misspelling of "especially"
Raw Output:
./onnxruntime/contrib_ops/cuda/fused_conv.cc:201:33: "expecially" is a misspelling of "especially"
|
Python format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Python format
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Optional Lint C++:
include/onnxruntime/core/providers/cuda/cuda_provider_options.h#L41
[cpplint] reported by reviewdog 🐶
Lines should be <= 120 characters long [whitespace/line_length] [2]
Raw Output:
include/onnxruntime/core/providers/cuda/cuda_provider_options.h:41: Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Optional Lint C++:
onnxruntime/contrib_ops/cuda/fused_conv.cc#L42
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:42: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
Optional Lint C++:
onnxruntime/contrib_ops/cuda/fused_conv.cc#L63
[cpplint] reported by reviewdog 🐶
Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:63: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
|
Optional Lint C++:
onnxruntime/contrib_ops/cuda/fused_conv.cc#L197
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:197: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
|
Optional Lint C++:
onnxruntime/contrib_ops/cuda/fused_conv.cc#L458
[cpplint] reported by reviewdog 🐶
Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
Raw Output:
onnxruntime/contrib_ops/cuda/fused_conv.cc:458: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5]
|
Optional Lint C++:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L6
[cpplint] reported by reviewdog 🐶
Found C system header after other header. Should be: cudnn_fe_call.h, c system, c++ system, other. [build/include_order] [4]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:6: Found C system header after other header. Should be: cudnn_fe_call.h, c system, c++ system, other. [build/include_order] [4]
|
Optional Lint C++:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L18
[cpplint] reported by reviewdog 🐶
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:18: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Optional Lint C++:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L79
[cpplint] reported by reviewdog 🐶
Almost always, snprintf is better than strcpy [runtime/printf] [4]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:79: Almost always, snprintf is better than strcpy [runtime/printf] [4]
|
Optional Lint C++:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc#L85
[cpplint] reported by reviewdog 🐶
If you can, use sizeof(str) instead of 1024 as the 2nd arg to snprintf. [runtime/printf] [3]
Raw Output:
onnxruntime/core/providers/cuda/cudnn_fe_call.cc:85: If you can, use sizeof(str) instead of 1024 as the 2nd arg to snprintf. [runtime/printf] [3]
|
Optional Lint C++:
onnxruntime/core/providers/cuda/nn/conv.cc#L18
[cpplint] reported by reviewdog 🐶
Include the directory when naming header files [build/include_subdir] [4]
Raw Output:
onnxruntime/core/providers/cuda/nn/conv.cc:18: Include the directory when naming header files [build/include_subdir] [4]
|