Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining MacOS 12 CI build agents to MacOS 13. #476

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

edgchen1
Copy link
Contributor

@edgchen1 edgchen1 commented Jun 28, 2023

Pass -gpu swiftshader_indirect emulator args as a workaround to get Android emulator running on the MacOS 13 hosted agents.

See actions/runner-images#7671

@edgchen1 edgchen1 changed the title Move CI build agents to MacOS 13. Move remaining MacOS 12 CI build agents to MacOS 13. Jun 28, 2023
@edgchen1 edgchen1 marked this pull request as ready for review June 29, 2023 01:22
@edgchen1 edgchen1 requested a review from a team as a code owner June 29, 2023 01:22
@edgchen1 edgchen1 merged commit b49c023 into main Jul 6, 2023
@edgchen1 edgchen1 deleted the edgchen1/update_mac_agents branch July 6, 2023 00:50
wenbingl added a commit that referenced this pull request Jul 6, 2023
Pass `-gpu swiftshader_indirect` emulator args as a workaround to get Android emulator running on the MacOS 13 hosted agents.

See actions/runner-images#7671

Co-authored-by: Wenbing Li <10278425+wenbingl@users.noreply.github.com>
jchen351 added a commit to microsoft/onnxruntime that referenced this pull request Sep 17, 2024
### Description
See microsoft/onnxruntime-extensions#476
and actions/runner-images#7671

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

### Current issue
- [ ] For default xcode 15.2, that come with the MacOS-13, We Need to
update the boost container header boost/container_hash/hash.hpp version
to pass the build
- [x] For xcode 14.2 The Build passed but the `Run React Native Detox
Android e2e Test` Failed.
Possible flaky test, #21969
- [x] For xcode 14.3.1 We encountered following issue in `Build React
Native Detox iOS e2e Tests`
```
ld: file not found: /Applications/Xcode_14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphonesimulator.a
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
Applied following code to the eof in both ios/Podfile and fixed the
issue
```
post_install do |installer|
    installer.generated_projects.each do |project|
        project.targets.each do |target|
            target.build_configurations.each do |config|
                config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
            end
        end
    end
end
```


- [x] facebook/react-native#32483

Applying changes to ios/Pofile
```
pre_install do |installer|
  # Custom pre-install script or commands
  puts "Running pre-install script..."

  # Recommended fix for facebook/react-native#32483
  # from facebook/react-native#32483 (comment)
  system("sed -i '' 's/typedef uint8_t clockid_t;//' \"${SRCROOT}/Pods/RCT-Folly/folly/portability/Time.h\"")
end
```

- [ ] Detox environment setting up exceeded time out of 120000ms during
iso e2e test


### dependent 

- [x] #21159

---------

Co-authored-by: Changming Sun <chasun@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants